Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the hard-coded Eclipse plugins from eclipse commandlet #904

Closed
Akuhana opened this issue Sep 26, 2022 · 1 comment · Fixed by #952
Closed

Remove the hard-coded Eclipse plugins from eclipse commandlet #904

Akuhana opened this issue Sep 26, 2022 · 1 comment · Fixed by #952
Assignees
Labels
enhancement New feature or request good-first-issue Good for newcomers

Comments

@Akuhana
Copy link
Contributor

Akuhana commented Sep 26, 2022

As a devonfw user, I want to change the update site in the properties file and see the changes reflect when executing the setup script of the Eclipse commandlet so that I don't need to update the hard coded lines every time plugins update_site or plugin_id needs to be updated. Changes have to be made to the following lines:

function doAddPlugin() {
if [ -z "${2}" ]
then
if [ "${1}" = "startexplorer" ]
then
doInstallEclipsePlugin "de.bastiankrol.startexplorer.feature.feature.group" "https://basti1302.github.io/startexplorer/update/"
elif [ "${1}" = "cobigen" ]
then
doInstallEclipsePlugin "com.devonfw.cobigen.eclipse.feature.feature.group,com.devonfw.cobigen.tempeng-freemarker,com.devonfw.cobigen.htmlplugin,com.devonfw.cobigen.javaplugin,com.devonfw.cobigen.jsonplugin,com.devonfw.cobigen.openapiplugin,com.devonfw.cobigen.propertyplugin,com.devonfw.cobigen.textmerger,com.devonfw.cobigen.tsplugin,com.devonfw.cobigen.tempeng-velocity,com.devonfw.cobigen.xmlplugin" "https://devonfw.com/cobigen/updatesite/stable/"
elif [ "${1}" = "terminal" ]
then
doInstallEclipsePlugin "org.eclipse.tm.terminal.feature.feature.group,org.eclipse.tm.terminal.view.feature.feature.group,org.eclipse.tm.terminal.control.feature.feature.group,org.eclipse.tm.terminal.connector.ssh.feature.feature.group,org.eclipse.tm.terminal.connector.telnet.feature.feature.group" "http://download.eclipse.org/tm/terminal/marketplace"
elif [ "${1}" = "anyedit" ]
then
doInstallEclipsePlugin "AnyEditTools.feature.group" "https://raw.githubusercontent.com/iloveeclipse/plugins/latest/"
elif [ "${1}" = "regexutil" ]
then
doInstallEclipsePlugin "com.ess.regexutil.feature.group" "http://regex-util.sourceforge.net/update/"
elif [ "${1}" = "templatevariables" ]
then
doInstallEclipsePlugin "net.sf.mmm.eclipse.templatevariables.feature.feature.group" "https://m-m-m.github.io/eclipse-templatevariables/latest"
elif [ "${1}" = "spotbugs" ]
then
doInstallEclipsePlugin "com.github.spotbugs.plugin.eclipse.feature.group" "https://spotbugs.github.io/eclipse/"
elif [ "${1}" = "checkstyle" ]
then
doInstallEclipsePlugin "net.sf.eclipsecs.feature.group" "https://checkstyle.org/eclipse-cs-update-site"
elif [ "${1}" = "github" ]
then
doInstallEclipsePlugin "org.eclipse.mylyn.github.feature.feature.group" "https://download.eclipse.org/egit/github/updates/"
elif [ "${1}" = "soapui" ]
then
doInstallEclipsePlugin "com.eviware.soapui.soapui_feature.feature.group" "http://www.soapui.org/eclipse/update/"
else
doAddPluginFromConfig "${SETTINGS_PATH}/eclipse/plugins/${1}.properties" "force-manual"
fi

@Akuhana Akuhana added enhancement New feature or request Team_IDE labels Sep 26, 2022
@Akuhana Akuhana self-assigned this Sep 27, 2022
Akuhana added a commit to Akuhana/devon_ide that referenced this issue Sep 29, 2022
@mustafaokyay mustafaokyay added the good-first-issue Good for newcomers label Oct 31, 2022
@hohwille hohwille changed the title Remove the deprecated installation of Eclipse plugins Remove the hard-coded Eclipse plugins from eclipse commandlet Nov 7, 2022
@Amueller36
Copy link
Contributor

I think I included the fixes for this issues in my Pull request here: #952

I didn't see that this was an issue itself, sorry.

@hohwille hohwille linked a pull request Nov 15, 2022 that will close this issue
@hohwille hohwille removed the Team_IDE label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good-first-issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants