Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#978 support for msi and adjustment of aws commandlet #1002

Merged
merged 11 commits into from
Dec 13, 2022
Merged

#978 support for msi and adjustment of aws commandlet #1002

merged 11 commits into from
Dec 13, 2022

Conversation

CREITZ25
Copy link
Member

@CREITZ25 CREITZ25 commented Dec 8, 2022

#978 support for msi and adjustment of aws commandlet

#978 support for msi and adjustment of aws commandlet
@CREITZ25 CREITZ25 self-assigned this Dec 8, 2022
@CREITZ25 CREITZ25 marked this pull request as draft December 8, 2022 13:15
@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) scripts related to shell scripts (bash and CMD) labels Dec 8, 2022
@CREITZ25 CREITZ25 requested review from cinnamon-coder-hub, hohwille and tobka777 and removed request for cinnamon-coder-hub December 8, 2022 13:17
#978 Support for msi and adjustment of aws commandlet
#978 support for msi and adjustment of aws commandlet
#978 support for msi and adjustment of aws commandlet
@CREITZ25
Copy link
Member Author

CREITZ25 commented Dec 9, 2022

This PR implements Issues #978, #992 and #964

#978 support for msi and adjustment of aws commandlet
@CREITZ25 CREITZ25 marked this pull request as ready for review December 9, 2022 09:18
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 thanks for this PR - great solution 👍
Your approach with AWS_CONFIG_FILE looks perfect to me. Also I love the simplification of the setup and the finally local installation.
BTW: In ${target_dir} I do not only find the extracted MSI content but also the MSI file again. Is there some option for msiexec to prevent this or should we simply delete the MSI copy ourselves after calling msiexec?

@hohwille
Copy link
Member

hohwille commented Dec 9, 2022

I linked the issues implemented by this PR. Can you also add them to the CHANGELOG?

@CREITZ25 CREITZ25 marked this pull request as draft December 12, 2022 07:49
@CREITZ25
Copy link
Member Author

BTW: In ${target_dir} I do not only find the extracted MSI content but also the MSI file again. Is there some option for msiexec to prevent this or should we simply delete the MSI copy ourselves after calling msiexec?

@hohwille: it was programmed that way, but some action accidentally erased the part. Now it is implemented again

@CREITZ25 CREITZ25 marked this pull request as ready for review December 12, 2022 11:45
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 Thanks for this PR. You did a really great job 👍 Thanks also for testing and implementing on all OS/platforms what is quite some work.
Can you address the legal issue with removing license information?
Then we could merge this and I will create a new issue for the rest of my suggestions for further improvement?

scripts/src/main/resources/scripts/command/aws Outdated Show resolved Hide resolved
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 Thanks for the quick rework.
I approve and will merge.
For the other discussion I created #1010

@hohwille hohwille merged commit 24abc89 into devonfw:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) scripts related to shell scripts (bash and CMD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws does not install a different version Support for MSI make aws config local
2 participants