-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#978 support for msi and adjustment of aws commandlet #1002
Conversation
#978 support for msi and adjustment of aws commandlet
#978 support for msi and adjustment of aws commandlet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CREITZ25 thanks for this PR - great solution 👍
Your approach with AWS_CONFIG_FILE
looks perfect to me. Also I love the simplification of the setup and the finally local installation.
BTW: In ${target_dir}
I do not only find the extracted MSI content but also the MSI file again. Is there some option for msiexec
to prevent this or should we simply delete the MSI copy ourselves after calling msiexec
?
I linked the issues implemented by this PR. Can you also add them to the CHANGELOG? |
BTW: In ${target_dir} I do not only find the extracted MSI content but also the MSI file again. Is there some option for msiexec to prevent this or should we simply delete the MSI copy ourselves after calling msiexec? @hohwille: it was programmed that way, but some action accidentally erased the part. Now it is implemented again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CREITZ25 Thanks for this PR. You did a really great job 👍 Thanks also for testing and implementing on all OS/platforms what is quite some work.
Can you address the legal issue with removing license information?
Then we could merge this and I will create a new issue for the rest of my suggestions for further improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#978 support for msi and adjustment of aws commandlet