Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1035: Github action to update ide-urls #1059

Merged
merged 13 commits into from
Apr 25, 2023

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Feb 15, 2023

This PR creates a GitHub Action to update urls in https://github.com/devonfw/ide-urls repository.

Related issue: #1035

@github-actions github-actions bot added bash related to bash shell or scripts SCM software-configuration-management (github actions, internal processes, git or github utilization) labels Feb 15, 2023
@alfeilex alfeilex linked an issue Feb 21, 2023 that may be closed by this pull request
5 tasks
@alfeilex alfeilex marked this pull request as ready for review February 21, 2023 14:32
@alfeilex
Copy link
Member Author

See results in forked ide-urls repo:

https://github.com/alfeilex/ide-urls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for your PR and this workflow. Nice work 👍
As the Java code executed from the workflow is not yet merged, we have to wait for this before we can merge and use this workflow. Thanks also for the hint about the token.

Copy link
Member

@tobka777 tobka777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should merge it and then test if it works incl. the tokens.

@hohwille hohwille added this to the release:2023.04.001 milestone Apr 13, 2023
@hohwille
Copy link
Member

#1086 needs to be implemented and merged before merging this PR to avoid clutter in git history.

@hohwille hohwille merged commit 0fe4eaa into devonfw:master Apr 25, 2023
@alfeilex alfeilex deleted the workflow/ide-urls branch May 11, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts SCM software-configuration-management (github actions, internal processes, git or github utilization)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github action to update ide-urls
3 participants