#1112: Version-prefix not working as expected

[Leosssss]

bugfix: add a condition to check if the version_prefix end with a digit

[Leosssss]

This PR is a bugfix PR, so we don't need to document this in the CHANGELOG?

[hohwille]

@Leosssss thanks for your PR. You figured out correct solutions to determine if the version_prefix ends with a digit and also how to escape a . to prevent it from matching any character. Great work that already works and solves the root problem described in the story 👍

Sorry, for being picky but could you do the escaping in both cases (I could still do JAVA_VERSION=17.0* and even with your fix, this would also match a potential version 1720.0 - theoretical case but lets get this fixed once and forever)? And could you also avoid the redundancy by using a local variable that is either empty or [^0-9] so you can reuse the same code without duplication?

[Leosssss]

@hohwille Thank you for your feedback, I still have a question, what should happen when JAVA_VERSION=17.0*? Should the regex return no results?

[hohwille]

To demonstrate my point, I have copied your code into this script:

#!/bin/bash

function version_prefix() {
  local version_prefix=$1
  local available_versions="${DEVON_IDE_HOME}/mirrors/java/available-versions"
  local resolved_version
  local regex="[0-9]*\."
  if [[ "${version_prefix}" =~ $regex ]]
  then
    version_prefix="${version_prefix/./\\.}"
  fi
  resolved_version="$(grep "^${version_prefix}" "${available_versions}" | head -n 1)"
  echo $resolved_version
}

version_prefix $@

I added the versions 17.1.0 and 17.10.0 to the available versions locally and get this:

./version-prefix.sh 17.0*
17.10.0

[hohwille]

For the build error, see the log:

Running test #4: test-shellcheck

In scripts/functions line 1288:
      version_prefix="$(echo "${version_prefix::-1}" | sed 's/[[:punct:]]/[.]/g')"
                        ^-- SC2001 (style): See if you can use ${variable//search/replace} instead.

For more information:
  https://www.shellcheck.net/wiki/SC2001 -- See if you can use ${variable//se...
[ERROR] Failed running test #4: test-shellcheck - exit code 1

[hohwille]

@Leosssss thanks for the rework. This PR fixes only one aspect of two from #1112.
However, I will approve and merge but keep #1112 open until also the second aspect ([^0-9] only if version_prefix ends with digit) is fixed what was the actual problem described in the story.

[hohwille]

@Leosssss thanks for your rework. 👍 You got very close but after looking deeper, I still found some problems. I will better do a constructive review and change the code accordingly and merge it. I hope this was a good learning on how fiddly the bash syntax is and how important testing with the different given examples is in IT business.