#1299 gcViewer version change/update not working #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bash
hohwille
reviewed
Aug 28, 2023
hohwille
reviewed
Aug 28, 2023
added the suggetion to remove the oldest .jar files in software, to only use the newest one
plus added check to not temp removed file
hohwille
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
@moritzLanger Excellent solution with your file loop and the -nt comparison. 👍
I fixed the indentation and initialized temp as local variable with empty value to prevent side-effects if the user may have set temp="foo" before your code gets invoked.
Ready for merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1299
fixed gcviewer script, to delete the old gcviewer software folder before installing new version