#1358: implemented disable workspace functionality #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added check for new DISABLE_WORKSPACE environment variables to intellij and android-studio added documentation for DISABLE_WORKSPACE environment variables to intellij and android-studio
github-actions
bot
added
bash
hohwille
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
@jan-vcapgemini thanks for your PR and fixing this issue fast. Your changes look good.
Thanks that you did not copy&paste the typo in the variable names I did initially in the story (DISLABLE vs. DISABLE) 👍
I did update the documentation directly as constructive review. It now does not say what is the default and should therefore be consistent.
Ready for merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses/Fixes: #1358
Implements: