Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#418: #377: added project commandlet, allow project to be inactive #419

Merged
merged 3 commits into from
May 26, 2020
Merged

#418: #377: added project commandlet, allow project to be inactive #419

merged 3 commits into from
May 26, 2020

Conversation

hohwille
Copy link
Member

Implementation of #418

@hohwille hohwille added enhancement New feature or request scripts related to shell scripts (bash and CMD) documentation related to documentation (AsciiDoc) commandlet related to commandlets (scripts/command/*) setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) update related to updating software or the entire devonfw-ide projects Auto cloning and import of projects. labels May 25, 2020
@hohwille hohwille added this to the release:2020.04.002 milestone May 25, 2020
@hohwille hohwille changed the title #418: #377: added project commandlet, allow project to be active/inac… #418: #377: added project commandlet, allow project to be inactive May 25, 2020
@hohwille hohwille requested review from maihacke and maybeec May 25, 2020 14:21
@maihacke
Copy link
Member

I think the active flag is a bit redundant, since disabling build and eclipse-import should be the same as active=false. But that is more a matter of taste.
Thanks for working on this feature. I like that is now separate command and not part of the ide script.

@maihacke maihacke merged commit b5054c5 into devonfw:master May 26, 2020
@hohwille hohwille mentioned this pull request Jun 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maybeec maybeec maybeec approved these changes

@maihacke maihacke Awaiting requested review from maihacke

Assignees
No one assigned
Labels
commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) enhancement New feature or request projects Auto cloning and import of projects. scripts related to shell scripts (bash and CMD) setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) update related to updating software or the entire devonfw-ide
Projects
None yet
Milestone
release:2020.04.002
Development

Successfully merging this pull request may close these issues.
3 participants
@hohwille @maihacke @maybeec