Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#557: minimize tools on setup #561

Merged
merged 4 commits into from
Apr 27, 2021
Merged

#557: minimize tools on setup #561

merged 4 commits into from
Apr 27, 2021

Conversation

hohwille
Copy link
Member

implements #557

@hohwille hohwille added enhancement New feature or request software software-package with 3rd party products setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) labels Apr 19, 2021
@hohwille hohwille added this to the release:2021.04.001 milestone Apr 19, 2021
@hohwille hohwille linked an issue Apr 19, 2021 that may be closed by this pull request
minimize setup by reducing DEVON_IDE_TOOLS #557
Closed
@hohwille hohwille requested a review from maybeec April 19, 2021 16:39
@hohwille
Copy link
Member Author

hohwille commented Apr 19, 2021 •
edited
Loading

I have tested this locally on my mac. Impacts:

  • scripts eclipse-main[.bat] and vscode-main[.bat] are now always created on setup (no matter what tools are configred (and therefore intellij-main[.bat] is not created on setup and needs an explicit call of devon intellij create-script).
  • I dropped angular CLI that always takes some extra time on setup. That means after setup now by default ng command is not available until the first call of devon ng or devon ng setup. This can be changed by projects by adding ng to DEVON_IDE_TOOLS
  • Currently integration-tests do not setup eclipse or vscode anymore during CI. Pro: faster, Contra: potential bugs not detected. We can also configure DEVON_IDE_TOOLS for integration-tests
  • Potentially also some impact for tutorials that I can not forsee

In case we want to include this into our release as I planned, we need somebody from the core team testing this explicitly in windows...

@hohwille hohwille merged commit 7511ca0 into devonfw:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maybeec maybeec Awaiting requested review from maybeec

Assignees
No one assigned
Labels
enhancement New feature or request setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) software software-package with 3rd party products
Projects
None yet
Milestone
release:2021.04.001
Development

Successfully merging this pull request may close these issues.

minimize setup by reducing DEVON_IDE_TOOLS
1 participant
@hohwille