Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no doIsQuiet yet for CobiGen #625

Merged
merged 1 commit into from
Nov 16, 2021
Merged

There is no doIsQuiet yet for CobiGen #625

merged 1 commit into from
Nov 16, 2021

Conversation

maybeec
Copy link
Member

@maybeec maybeec commented Nov 16, 2021

as it is done with --verbose it does not make any sense and it's not working as expected

as it is done with --verbose it does not make any sense and it's not working as expected
@hohwille hohwille added this to the release:2021.08.001 milestone Nov 16, 2021
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maybeec thanks for this PR 👍
If --verbose is not supported or does not make sense (to have by default) this change is perfectly fine. Writing output to /dev/null for quite also does not make sense.
So I approve and merge.

@hohwille hohwille merged commit 3be34c7 into master Nov 16, 2021
@hohwille hohwille added cobigen code generator tool commandlet related to commandlets (scripts/command/*) enhancement New feature or request labels Nov 16, 2021
@CREITZ25 CREITZ25 deleted the maybeec-patch-2 branch January 27, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cobigen code generator tool commandlet related to commandlets (scripts/command/*) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants