Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#641: improve mirrors #647

Merged
merged 9 commits into from
Dec 17, 2021
Merged

#641: improve mirrors #647

merged 9 commits into from
Dec 17, 2021

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Dec 16, 2021

implements #641 and addes the suggested improvements after PR #643 was already merged.
I also found several bugs that I fixed alongside.
For the record: This PR MUST be merged before creating a release as I had to also merge devonfw/ide-mirrors#1 so this PR can build green.

hohwille and others added 5 commits December 16, 2021 09:32
* Update jasypt.asciidoc

* Update software.asciidoc

* Update java.asciidoc

Co-authored-by: Malte Brunnlieb <maybeec@users.noreply.github.com>
* Update jasypt.asciidoc

* Update software.asciidoc

* Update java.asciidoc

* Update usage.asciidoc

Co-authored-by: Malte Brunnlieb <maybeec@users.noreply.github.com>
@hohwille hohwille added this to the release:2021.12.002 milestone Dec 16, 2021
@hohwille hohwille added config should be configurable or configuration change eclipse related to Eclipse IDE enhancement New feature or request intellij IntelliJ IDE from Jet-Brains java related to Java code, the Java Virtual Machine and directly related tooling (OpenJDK, Adoptium) linux specific for linux OS (debian, ubunutu, suse, etc.) macOS specific for Apple MacOS maven related to apache maven build tool scripts related to shell scripts (bash and CMD) software software-package with 3rd party products update related to updating software or the entire devonfw-ide vscode Microsoft visual studio code windows specific for Microsoft Windows OS labels Dec 16, 2021
@hohwille
Copy link
Member Author

For some strange reasons I got conflicted with myself (maybe due to odd merges).
Resolving conflicts in the browser is not much fun.
I will double check by compaing my original local FB with this one after merge.

@hohwille
Copy link
Member Author

For some strange reasons I got conflicted with myself (maybe due to odd merges). Resolving conflicts in the browser is not much fun. I will double check by compaing my original local FB with this one after merge.

OK. Verified. Only two new lines have been added due to conflict resolution but otherwise functions file is identical. Other changes are also fine but small and easy to review.

@hohwille
Copy link
Member Author

Build failed with error:

*** Setting up mvn ***

******** ATTENTION ********
ERROR: Download of java in version 11.0.9.1_1 failed after trying 1 mirror(s).

Ouch. There are doEcho statements that should print some messages before this error actually occurrs.
I have to find a way to reproduce this as it did not happen on my machine. May the conflict resolution broke something that I missed.

@hohwille
Copy link
Member Author

I will still address the quiet vs. verbose issue with dependent setups.
FYI: The tests have not been fixed by my last commit (code style) but by this commit devonfw/ide-mirrors@b8059d0

@hohwille
Copy link
Member Author

I have tested this with arbitrary variants and combinations (and found and fixed bugs I made temporary). It is quite astounding how many combinations of tools, versions, operating-systems, etc. we do support.
I will merge this now and would be very happy if some people could then get a latest SNAPSHOT from OSSRH nexus (https://github.com/devonfw/ide/blob/master/documentation/setup.asciidoc#testing-snapshot-releases).

@hohwille hohwille merged commit 1b535ea into devonfw:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config should be configurable or configuration change eclipse related to Eclipse IDE enhancement New feature or request intellij IntelliJ IDE from Jet-Brains java related to Java code, the Java Virtual Machine and directly related tooling (OpenJDK, Adoptium) linux specific for linux OS (debian, ubunutu, suse, etc.) macOS specific for Apple MacOS maven related to apache maven build tool scripts related to shell scripts (bash and CMD) software software-package with 3rd party products update related to updating software or the entire devonfw-ide vscode Microsoft visual studio code windows specific for Microsoft Windows OS
Projects
None yet
3 participants