#696 added new COBIGEN_HOME environment variable to devon.properties #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hohwille
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
@jan-vcapgemini thanks for this PR and fix 👍
Does this work when the folder does not yet exists and will cobigen create it?
It slighly conflicts with requirements from issue #5 but as we have a bug issue fixed this way, So I am happy to approve and merge. Users who do not use cobigen can still unset the property in the own devon.properties if they have problems with this while it is more important that things work easily OOTB.
Side-node: Typically env vars like <Tool>_HOME point to the software installation folder of that tool rather than a config folder. However, this is more a question of cobigen than devonfw-ide and most likely a choice already made that can not be changed easily.
hohwille
added
config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses: devonfw/cobigen#1430 and implements #696