Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for correct .m2 folder #716

Closed
wants to merge 2 commits into from
Closed

fix for correct .m2 folder #716

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0595e24
#706: add setting path as parameter
tobka777 Mar 15, 2022
ee3e98a
Merge branch 'master' into fix/706-m2-setting
hohwille May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions scripts/src/main/resources/scripts/command/mvn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ function doCheckNoSnapshots() {

function doRunBuild() {
local maven_cmd="${MVN}"
local maven_arguments=""
local maven_arguments="--settings=${DEVON_IDE_HOME}/conf/.m2/settings.xml"
Copy link
Member

@hohwille hohwille May 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont we need to export this to MAVEN_ARGS via devon.properties?
This only applies when mvn is called via devon as wrapper command.
However, I see this bug occurring all the time without devon command being involved as wrapper but only to setup env variables.
My assumption is that the actual bug #706 somehow originates from m2e eclipse plugin and happens since a newer version of that plugin so it did not happen before and suddenly came with some ide or eclipse update...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current "hack" to relocate the settings to this directory happens here:
https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/scripts/devon.properties#L19

So far this worked well for commandline (with and without devon wrapper) as well as for all supported IDEs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later down the maven_arguments are overridden (maven_arguments="${MAVEN_ARGS}") so with maven 3.x your change will have no effect. As maven 4.x is still not released, this PR does not work or make a big difference.
Should we close this or should we change the later code in this PR to honor existing maven_arguments and append to it instead of overriding.

if [ -x mvnw ]
then
maven_cmd="./mvnw"
Expand All @@ -319,17 +319,17 @@ function doRunBuild() {
if [ "${?}" == 2 ]
then
# Maven version is lower than 4.0 (3.x)
maven_arguments="${MAVEN_ARGS}"
fi
maven_arguments="${MAVEN_ARGS}"
fi
Comment on lines +322 to +323
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did those changes happen by accident? Seems the indentation was messed by your editor somehow.

fi
if doIsQuiet
then
if [ -n "${maven_arguments}" ]
then
maven_arguments="-q ${maven_arguments}"
else
maven_arguments="-q"
fi
then
maven_arguments="-q ${maven_arguments}"
else
maven_arguments="-q"
fi
fi
if [ -n "${maven_arguments}" ]
then
Expand Down