#690: add support for rancher desktop

[cinnamon-coder-hub]

fixing #690.

• Additionally an issue with the mirror has to be and will be fixed soon. There is a formating problem when uploading to github, similar as @CREITZ25 experienced once (PR waiting for merge).

[tobka777]

So I tested rancher for mac and your solution works with hdiutil.
Instead of .dmg you could also use the zip (https://github.com/rancher-sandbox/rancher-desktop/releases/download/v1.2.1/Rancher.Desktop-1.2.1-mac.x86_64.zip) file, but that's fine. Then you would not need to mount the dmg.
I still had to adjust the name of the .dmg.

[hohwille]

@cinnamon-coder-hub Excellent. Thanks for your updates 👍
We should surely do more testing and collect early user-feedback but now approved and ready to be merged.

[hohwille]

We create extra issues for doc improvements (installation help, screenshot of install options) and improvement for #742 as well as MacOS testing - rest is fine so ready for merge

[hohwille]

@cinnamon-coder-hub I did some constructive review with 2 direct commits of small and formal improvements.
Further I just wanted to get this ready for merge but found two more small things that I added as review comments. Please have a look.

[hohwille]

@cinnamon-coder-hub Thanks for all the rework and great that you could already integrate vpnkit. I consider this as ready for merge. Great job 👍

[hohwille]

Shellcheck still fails:

In scripts/command/docker line 157:
  partialUrl=$(curl -Ls -o /dev/null -w %{url_effective} https://github.com/sakai135/wsl-vpnkit/releases/latest)
                                         ^-- SC1083: This { is literal. Check expression (missing ;/\n?) or quote it.
                                                       ^-- SC1083: This } is literal. Check expression (missing ;/\n?) or quote it.


In scripts/command/docker line 173:
  echo 'mv wsl-vpnkit.tar.gz $env:USERPROFILE' >> vpnkit-setup.ps1
  ^-- SC2129: Consider using { cmd1; cmd2; } >> file instead of individual redirects.
       ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that.


In scripts/command/docker line 175:
  echo 'pushd $env:USERPROFILE' >> vpnkit-setup.ps1
       ^----------------------^ SC2016: Expressions don't expand in single quotes, use double quotes for that.


In scripts/command/docker line 176:
  echo 'wsl --import wsl-vpnkit $env:USERPROFILE\wsl-vpnkit wsl-vpnkit.tar.gz --version 2' >> vpnkit-setup.ps1
       ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that.

I will quickly fix this oneline to get this merged and do release today...