Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix passing args to terraform and helm on proxy usage #785

Merged
merged 1 commit into from
Jun 9, 2022
Merged

fix passing args to terraform and helm on proxy usage #785

merged 1 commit into from
Jun 9, 2022

Conversation

CREITZ25
Copy link
Member

@CREITZ25 CREITZ25 commented Jun 9, 2022 •
edited by hohwille
Loading

when terraform and helm are used as proxy commandlets in devonfw-ide the arguments are not properly passed and as a result it is not working:

# devon helm env
The Kubernetes package manager

Common actions for Helm:

- helm search:    search for charts
- helm pull:      download a chart to your local directory to view
- helm install:   upload the chart to Kubernetes
- helm list:      list releases of charts
...

so the env parameter is not passed to helm. Same problem exists for terraform.

@CREITZ25
bugfix terraform and helm
a23a21e 
bugfix terraform and helm
@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) scripts related to shell scripts (bash and CMD) labels Jun 9, 2022
hohwille
hohwille approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 Excellent. Thanks for finding and fixing. 👍

@hohwille hohwille added this to the release:2022.04.003 milestone Jun 9, 2022
@hohwille hohwille merged commit 85f6290 into master Jun 9, 2022
@hohwille hohwille changed the title bugfix terraform and helm fix passing args to terraform and helm on proxy usage Jun 9, 2022
@CREITZ25 CREITZ25 deleted the bugfix-terraform-and-helm branch January 27, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees
No one assigned
Labels
bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) scripts related to shell scripts (bash and CMD)
Projects
None yet
Milestone
release:2022.04.003
Development

Successfully merging this pull request may close these issues.
2 participants
@CREITZ25 @hohwille