Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#786 Improve Windows Terminal with powershell #853

Merged
merged 6 commits into from
Aug 29, 2022
Merged

#786 Improve Windows Terminal with powershell #853

merged 6 commits into from
Aug 29, 2022

Conversation

CREITZ25
Copy link
Member

#786 Improve Windows Terminal with powershell

#786 Improve Windows Terminal with powershell
@CREITZ25 CREITZ25 requested a review from tobka777 August 22, 2022 15:05
@CREITZ25 CREITZ25 self-assigned this Aug 22, 2022
@github-actions github-actions bot added bash related to bash shell or scripts documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD) windows specific for Microsoft Windows OS labels Aug 22, 2022
Copy link
Member

@tobka777 tobka777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 looks very good. Have you done a test on Windows starting with a new devon installation?

@tobka777
Copy link
Member

Please solve the merge conflict with setup.bat.

@tobka777 tobka777 marked this pull request as ready for review August 23, 2022 10:26
@CREITZ25
Copy link
Member Author

@tobka777 Now it is testet in a new environment, and I had to correct something, because an already fixed bug was in my installation. I don't know why...

@CREITZ25 CREITZ25 requested a review from tobka777 August 24, 2022 10:26
@tobka777 tobka777 linked an issue Aug 24, 2022 that may be closed by this pull request
@tobka777 tobka777 requested a review from hohwille August 24, 2022 10:45
#855 Feature/wt change title from devon <tool> to devoffw <tool>
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 Thanks for this PR and great that you could even solve this for PowerShell and complete the story about Windows Terminal. 👍
You also changed the registry files for CMD and gitbash alongside with this PR. I can not see the diffs here on github as it treats them as binary. What was the reason for that change?

@CREITZ25
Copy link
Member Author

You are not able to see changes because these are reg files. The change in the reg files are:
From:
"%USERPROFILE%\AppData\Local\Microsoft\WindowsApps\wt.exe" -w 0 new-tab -p "Windows Powershell" --title "devon PowerShell" -d %L PowerShell.exe -NoExit -Command "devon"
To:
"%USERPROFILE%\AppData\Local\Microsoft\WindowsApps\wt.exe" -w 0 new-tab -p "Windows Powershell" --title "devonfw PowerShell" -d %L PowerShell.exe -NoExit -Command "devon"

@hohwille
Copy link
Member

I corrected it, but I add it to the other (the last) issue/PR

I was more asking about the reg files for CMD and gitbash but I will assume that you also changed those accordingly.
So is this hex(2) blabla magic just an hex conversion of the actual command that you somehow encode with a specific tool?
Could you be so kind and document this magic process e.g. in #701 or even better in a README here?

@hohwille hohwille added this to the release:2022.04.004 milestone Aug 29, 2022
@hohwille hohwille merged commit adfcbfc into devonfw:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD) windows specific for Microsoft Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Windows Terminal with powershell
3 participants