Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#832: Solution for unstable update sites #881

Merged
merged 48 commits into from
Sep 16, 2022
Merged

#832: Solution for unstable update sites #881

merged 48 commits into from
Sep 16, 2022

Conversation

alfeilex
Copy link
Member

No description provided.

@alfeilex
update-sites
0de1122
@alfeilex
Update eclipse-update-sites.asciidoc
ac86394
@alfeilex
Update eclipse-update-sites.asciidoc
bc76b2f
@alfeilex
Update eclipse-update-sites.asciidoc
088449f
@alfeilex
Update eclipse-update-sites.asciidoc
a4c4dec
@alfeilex
Merge branch 'devonfw:master' into eclipse-update-sites
664a418
@alfeilex
update sites
29e5dd2
@alfeilex
Merge branch 'devonfw:master' into eclipse-update-sites
1107d0c
@alfeilex
modify eclipse command
e830694
@alfeilex
Merge branch 'eclipse-update-sites' of https://github.com/alfeilex/ide …
9e2a622 
…into eclipse-update-sites
@alfeilex
change eclipse command
8e22cb9
@alfeilex
Update eclipse.asciidoc
db03244
@alfeilex
Update eclipse.asciidoc
b92f1dc
@alfeilex
Update eclipse.asciidoc
d8b74b8
@alfeilex
Update CHANGELOG.asciidoc
ea8f72e
@alfeilex
fix shellcheck
8c5499f
@alfeilex
fix version
8e822d2
@alfeilex
Update eclipse
7e1b016
@alfeilex
Update CHANGELOG.asciidoc
e10e65d
@alfeilex
Merge branch 'devonfw:master' into eclipse-update-sites
f510de2
@alfeilex
Update CHANGELOG.asciidoc
8952507
@alfeilex
Update eclipse
add6bb4
@alfeilex
Update eclipse
ed490f5
@alfeilex
Update eclipse
0db2d29
@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD) labels Sep 12, 2022
@alfeilex alfeilex changed the title Eclipse update sites #832: Solution for unstable update sites Sep 12, 2022
@alfeilex alfeilex linked an issue Sep 12, 2022 that may be closed by this pull request
Solution for unstable update sites #832
Closed
@alfeilex
Copy link
Member Author

alfeilex commented Sep 16, 2022 •
edited
Loading

Should there be an error message if the plugin_url is empty? If there is no link to the original update siteanymore. then we should change this condition.

https://github.com/alfeilex/ide/blob/38f37a7f9b78f3448fde95b8f64a4ff7b603c6a1/scripts/src/main/resources/scripts/command/eclipse#L296

hohwille
hohwille approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex excellent. Thanks for the rework. 👍
Ready for merge.

@hohwille
Copy link
Member

Should there be an error message if the plugin_url is empty?

Thanks for taking care and asking. But that is fine as it was: this property should always be present and filled.

@hohwille hohwille merged commit e7c2e3d into devonfw:master Sep 16, 2022
@alfeilex alfeilex deleted the eclipse-update-sites branch October 5, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees
No one assigned
Labels
bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)
Projects
None yet
Milestone
release:2022.08.002
Development

Successfully merging this pull request may close these issues.

Solution for unstable update sites
2 participants
@alfeilex @hohwille