Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#847: #826: fixes #938

Merged
merged 2 commits into from
Oct 11, 2022
Merged

#847: #826: fixes #938

merged 2 commits into from
Oct 11, 2022

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Oct 11, 2022

Small fixes and improvements to changes from #826 and part of #933:

@hohwille hohwille added this to the release:2022.08.004 milestone Oct 11, 2022
@github-actions github-actions bot added bash related to bash shell or scripts scripts related to shell scripts (bash and CMD) labels Oct 11, 2022
@hohwille
Copy link
Member Author

How come that the build of this PR is green?
The function doUpdateMirrors will be added in PR #934 and is missing here.
Therefore test-function-doc should fail.
Shouldn't shellcheck also notice this and break the build?

@github-actions github-actions bot added the documentation related to documentation (AsciiDoc) label Oct 11, 2022
@hohwille
Copy link
Member Author

hohwille commented Oct 11, 2022

Documentation of functions and function declarations are in sync.
Awesome!
[SUCCESS] Succeeded running test #0: test-functions-doc

OK. It has been vice versa:
doUpdateMirrors was called but not declared. As it was not declared the test did not fail as no declared function was missing in the documentation.

The question is if we can detect if some do[A-Z].* is called but never declared.

Update: I created #939 for this idea.

@hohwille hohwille merged commit 643deec into devonfw:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant