#982: Add recommendation feature and clean setup option to vscode

CHANGELOG.asciidoc

@@ -6,6 +6,7 @@ This file documents all notable changes to https://github.com/devonfw/ide[devonf
 
 Release with small but important bugfixes:
 
+* https://github.com/devonfw/ide/issues/982[#982]: Add recommendation feature and clean setup option to vscode
 * https://github.com/devonfw/ide/issues/966[#966]: npm detection not reliable and redundant
 * https://github.com/devonfw/ide/issues/954[#954]: First install removes all folders from user path
 * https://github.com/devonfw/ide/issues/956[#956]: no matches found error if software folder missing

documentation/vscode.asciidoc

@@ -22,6 +22,7 @@ You may also supply additional arguments as `devon vscode «args»`. These are e
 |`ws-re[verse]`  |reverse merge changes from workspace into settings
 |`ws-reverse-add`|reverse merge adding new properties
 |`create-script` |create launch script for this IDE, your current workspace and your OS
+|`clean-setup`   |clean VSCode setup without plugins and recommendations
 |=======================
 
 
@@ -42,7 +43,7 @@ The variables are defined as following:
 
 In general you should try to stick with the configuration pre-defined by your project. But some plugins may be considered as personal flavor and are typically not predefined by the project config. Such plugins should be shipped with your link:settings.asciidoc[settings] as described above with `plugin_active=false` allowing you to easily install it manually. Surely, you can easily add plugins via the UI of VS code. However, be aware that some plugins may collect sensitive data or could introduce other vulnerabilities. So consider the governance of your project and talk to your technical lead before installing additional plugins that are not pre-defined in your link:settings.asciidoc[settings].
 
-As maintainer of the link:settings.asciidoc[settings] for your project you should avoid to ship too many plugins that may waste resources but are not used by every developer. By configuring additional plugins with `plugin_active=false` you can give your developers the freedom to install some additional plugins easily.
+As maintainer of the link:settings.asciidoc[settings] for your project you should avoid to ship too many plugins that may waste resources but are not used by every developer. By configuring additional plugins with `plugin_active=false` you can give your developers the freedom to install some additional plugins easily. In addition, deactivated plugins are recommended to the user by an existing link:https://code.visualstudio.com/docs/editor/extension-marketplace#_workspace-recommended-extensions[feature] of VS Code via prompt.
 
 === cleaning plugins on update
 
@@ -51,4 +52,4 @@ If you want to strictly manage the plugins for `VS code` in your project, you ca
 clean_plugins_on_update=true
 ```
 
-This will wipe all plugins when an update of `VS code` is performed (e.g. via `devon ide update`) and reinstall all configured plugins. While this gives you more control over the governance of the plugins and allows to remove a plugin later during project lifecycle. However, this will delete all manually installed plugins automatically without asking.
+This will wipe all plugins when an update of `VS code` is performed (e.g. via `devon ide update`) and reinstall all configured plugins. While this gives you more control over the governance of the plugins and allows to remove a plugin later during project lifecycle. However, this will delete all manually installed plugins automatically without asking.

scripts/src/main/resources/scripts/command/vscode

@@ -32,6 +32,10 @@ function doSetup() {
   fi
 }
 
+function doCleanSetup() {
+  doInstall "vscode" "${VSCODE_VERSION}" "${1}"
+}
+
 function cleanupPlugins() {
   clean_plugins_on_update="false"
   doLoadProperties "${SETTINGS_PATH}"/vscode/vscode.properties
@@ -48,6 +52,7 @@ function cleanupPlugins() {
 function doAddPlugins() {
   local file
   local pluginsToInstall=()
+  local pluginsToRecommend=()
   for file in "${SETTINGS_PATH}"/vscode/plugins/*.properties
   do
     if [ -f "${file}" ]
@@ -61,13 +66,20 @@ function doAddPlugins() {
       elif [ "${plugin_active}" = "true" ]
       then
         pluginsToInstall+=("${plugin_id}")
+      else    
+        pluginsToRecommend+=("\"${plugin_id}\"")
       fi
     fi
   done
   if [ "${#pluginsToInstall}" -gt 0 ]
   then
     doAddPlugin "${pluginsToInstall[@]}"
   fi
+  if [ "${#pluginsToRecommend}" -gt 0 ]
+  then
+    local IFS=,
+    doAddRecommendations "${pluginsToRecommend[*]}"
+  fi
 }
 
 function doAddPlugin() {
@@ -126,6 +138,18 @@ function doStartVsCode() {
   doRunVsCode "${WORKSPACE_PATH}"
 }
 
+function doAddRecommendations() {
+  doEcho "add recommendations..."
+  local extensions="${WORKSPACE_PATH}/.vscode/extensions.json"
+  if [ -f "${extensions}" ]
+  then
+    rm "${extensions}"
+    echo "{\"recommendations\":[${1}]}" >> "${extensions}"
+  else
+    echo "{\"recommendations\":[${1}]}" >> "${extensions}"
+  fi
+}
+
 # CLI
 if [ "${1}" = "-h" ] || [ "${1}" = "help" ]
 then
@@ -140,6 +164,7 @@ then
   echo " ws-re[verse]                   reverse merge changes from workspace into settings"
   echo " ws-reverse-add                 reverse merge adding new properties"
   echo " create-script                  create vscode-${WORKSPACE} script if not already exists"
+  echo " clean-setup                    clean VSCode setup without plugins and recommendations"
   exit
 fi
 if [ -z "${1}" ]
@@ -180,6 +205,11 @@ do
     shift
     doAddPlugin "${@}"
     exit ${?}
+  elif [ "${1}" = "clean-setup" ]
+  then
+    doCleanSetup "${2}"
+    doStartVsCode
+    exit
   else
     doFail "Undefined argument: ${1}"
   fi