Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#941:Added (folders + code) frame for discussion #994

Conversation

cinnamon-coder-hub
Copy link
Member

@cinnamon-coder-hub cinnamon-coder-hub commented Nov 27, 2022

Related to #941.
This PR is mainly supposed to give us a basic mutual folder structure to work on the issue #941 and further issues related to the new ide-mirror approach. Locally I was able to successfully execute the command mvn compile. Still, this may not be enough and some files may need to be added to complete the folder structure for propert usage with maven.
As template I used the subfolders of the 'configurator' folder, but left out some files inside 'bin/src/test/resources/templates' as I'm not sure if they are needed.
To discuss the generation and editing process of the urls-folders I included most of the related code I worked on recently. There are four classes that relate to the folder structures hierarchy, starting with the UrlRepository class, followed by UrlTool, UrlEdition and UrlVersion (for a better understanding I recommend reading Jörgs comments inside the related issue #941). A last class (I'm currently working on locally ) should be UrlFile. An object of this class will be related to an file, with download urls of a specific tool (with an specific edition), inside a version folder and there will be methods for reading, manipulating and finally saving the the files (potentially modified) content.
To have a relation between the before mentioned hierarchies, a child-parent structure was introduced. Recently I tried to overcome some smaller unpleasant issues by writing the three subclasses UrlHasChildArtifact, UrlHasParentChildArtifact and UrlHasParentArtifact, as an result of talks with @hohwille.
Those subclasses are inherited from UrlArtifact. Now I'll be happy to get some feedback and also welcome @Amueller36 to this project.

@github-actions github-actions bot added the bash related to bash shell or scripts label Nov 27, 2022
@hohwille hohwille added the mirrors ide-mirrors repository (deprecated/obsolete) label Nov 28, 2022
@hohwille hohwille added this to the release:2022.12.001 milestone Nov 28, 2022
url-updater/bin/pom.xml Outdated Show resolved Hide resolved
url-updater/pom.xml Outdated Show resolved Hide resolved
@hohwille
Copy link
Member

Build failed with this error that seems unrelated to your PR:

curl: (22) The requested URL returned error: 503 
Failed to download https://github.com/adoptium/temurin19-binaries/releases/download/jdk-19%2B36/OpenJDK19U-jdk_x64_linux_hotspot_19_36.tar.gz with exit code 22

******** ATTENTION ********
Download of java in version 19_36 failed after trying 1 mirror(s).

It is great to have automated tests. However, in our case things are not as stable as desired and falsely breaking tests are a problem...

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cinnamon-coder-hub thanks for the rework. 👍
I will merge as a starting point for collaboration.
We still have to establish code-style rules like having JavaDoc and Junit-tests but fine to add this on the go.

@hohwille
Copy link
Member

This PR is obsolete and was replaced by #1000.

@hohwille hohwille closed this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts mirrors ide-mirrors repository (deprecated/obsolete)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants