-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#941:Added (folders + code) frame for discussion #994
#941:Added (folders + code) frame for discussion #994
Conversation
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlVersion.java
Outdated
Show resolved
Hide resolved
Build failed with this error that seems unrelated to your PR:
It is great to have automated tests. However, in our case things are not as stable as desired and falsely breaking tests are a problem... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cinnamon-coder-hub thanks for the rework. 👍
I will merge as a starting point for collaboration.
We still have to establish code-style rules like having JavaDoc and Junit-tests but fine to add this on the go.
This PR is obsolete and was replaced by #1000. |
Related to #941.
This PR is mainly supposed to give us a basic mutual folder structure to work on the issue #941 and further issues related to the new ide-mirror approach. Locally I was able to successfully execute the command
mvn compile
. Still, this may not be enough and some files may need to be added to complete the folder structure for propert usage with maven.As template I used the subfolders of the 'configurator' folder, but left out some files inside 'bin/src/test/resources/templates' as I'm not sure if they are needed.
To discuss the generation and editing process of the urls-folders I included most of the related code I worked on recently. There are four classes that relate to the folder structures hierarchy, starting with the UrlRepository class, followed by UrlTool, UrlEdition and UrlVersion (for a better understanding I recommend reading Jörgs comments inside the related issue #941). A last class (I'm currently working on locally ) should be UrlFile. An object of this class will be related to an file, with download urls of a specific tool (with an specific edition), inside a version folder and there will be methods for reading, manipulating and finally saving the the files (potentially modified) content.
To have a relation between the before mentioned hierarchies, a child-parent structure was introduced. Recently I tried to overcome some smaller unpleasant issues by writing the three subclasses UrlHasChildArtifact, UrlHasParentChildArtifact and UrlHasParentArtifact, as an result of talks with @hohwille.
Those subclasses are inherited from UrlArtifact. Now I'll be happy to get some feedback and also welcome @Amueller36 to this project.