Resolve babel vulnerability #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the babel-traverse version which is vulnerable to arbitrary code execution. istanbul author message: This module is no longer maintained, try this instead: npm i nyc Visit https://istanbul.js.org/integrations for other alternatives. See https://www.npmjs.com/package/istanbul
Another code coverage tool that is recommended by the author of nyc.
|
Is everything working like before? Do we need to adjust / update tests etc? |
@auvipy I looked for it but it seems there was no code directly calling |
|
@auvipy shall I merge this pull request? |
auvipy
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
Dependabot reported a vulnerability in babel-traverse. This in itself is not an issue for this project since we're not compiling code that's specifically crafted by an attacker with it. However, while looking at package-lock-json I found out that the reason for installing
babel-traverseisistanbul. And that package has been deprecated. This PR replaces istanbul with nyc.Bug/Ticket Tracker
https://github.com/devour-js/devour-client/security/dependabot/26
Documentation
https://www.npmjs.com/package/istanbul
Third-Party
nyc - it was recommended by the author of istanbul as its replacement. It also has a permissible ISC license, functionally equivalent to the simplified BSD and MIT licenses.