refactor: simplify the naming of Operations to make it easier for the…

… caller Signed-off-by: Daniel Hu <tao.hu@merico.dev>
devstream-io · Aug 9, 2022 · 61bccd0 · 61bccd0
1 parent 33c62a8
commit 61bccd0
Show file tree

Hide file tree

Showing 67 changed files with 105 additions and 108 deletions.
diff --git a/internal/pkg/plugin/argocd/create.go b/internal/pkg/plugin/argocd/create.go
@@ -10,7 +10,7 @@ import (
 func Create(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.SetDefaultConfig(&defaultHelmConfig),
 			helm.Validate,
 		},

diff --git a/internal/pkg/plugin/argocd/delete.go b/internal/pkg/plugin/argocd/delete.go
@@ -8,7 +8,7 @@ import (
 func Delete(options map[string]interface{}) (bool, error) {
 	// 1. config delete operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.SetDefaultConfig(&defaultHelmConfig),
 			helm.Validate,
 		},

diff --git a/internal/pkg/plugin/argocd/read.go b/internal/pkg/plugin/argocd/read.go
@@ -13,7 +13,7 @@ const (
 func Read(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config read operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.SetDefaultConfig(&defaultHelmConfig),
 			helm.Validate,
 		},

diff --git a/internal/pkg/plugin/argocd/update.go b/internal/pkg/plugin/argocd/update.go
@@ -9,7 +9,7 @@ import (
 func Update(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config update operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.SetDefaultConfig(&defaultHelmConfig),
 			helm.Validate,
 		},

diff --git a/internal/pkg/plugin/argocdapp/create.go b/internal/pkg/plugin/argocdapp/create.go
@@ -11,10 +11,10 @@ import (
 func Create(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			validate,
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			kubectl.ProcessByContent(
 				"create", file.NewTemplate().FromContent(templateFileLoc),
 			),

diff --git a/internal/pkg/plugin/argocdapp/delete.go b/internal/pkg/plugin/argocdapp/delete.go
@@ -9,10 +9,10 @@ import (
 func Delete(options map[string]interface{}) (bool, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			validate,
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			kubectl.ProcessByContent(
 				"delete", file.NewTemplate().FromContent(templateFileLoc),
 			),

diff --git a/internal/pkg/plugin/argocdapp/read.go b/internal/pkg/plugin/argocdapp/read.go
@@ -7,7 +7,7 @@ import (
 func Read(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			validate,
 		},
 		GetStateOperation: getDynamicState,

diff --git a/internal/pkg/plugin/artifactory/create.go b/internal/pkg/plugin/artifactory/create.go
@@ -9,7 +9,7 @@ import (
 func Create(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		ExecuteOperations:   helm.DefaultCreateOperations,

diff --git a/internal/pkg/plugin/artifactory/delete.go b/internal/pkg/plugin/artifactory/delete.go
@@ -8,7 +8,7 @@ import (
 func Delete(options map[string]interface{}) (bool, error) {
 	// 1. config delete operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		ExecuteOperations: helm.DefaultDeleteOperations,

diff --git a/internal/pkg/plugin/artifactory/read.go b/internal/pkg/plugin/artifactory/read.go
@@ -9,7 +9,7 @@ import (
 func Read(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config read operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		GetStateOperation: helm.GetPluginAllState,

diff --git a/internal/pkg/plugin/artifactory/update.go b/internal/pkg/plugin/artifactory/update.go
@@ -9,7 +9,7 @@ import (
 func Update(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config update operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		ExecuteOperations: helm.DefaultUpdateOperations,

diff --git a/internal/pkg/plugin/devlake/create.go b/internal/pkg/plugin/devlake/create.go
@@ -10,7 +10,7 @@ import (
 func Create(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			kubectl.ProcessByContent(
 				"create", file.NewTemplate().FromRemote(devLakeInstallYAMLDownloadURL),
 			),

diff --git a/internal/pkg/plugin/devlake/delete.go b/internal/pkg/plugin/devlake/delete.go
@@ -9,7 +9,7 @@ import (
 func Delete(options map[string]interface{}) (bool, error) {
 	// 1. config delete operations
 	runner := &plugininstaller.Operator{
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			kubectl.ProcessByContent(
 				"delete", file.NewTemplate().FromRemote(devLakeInstallYAMLDownloadURL),
 			),

diff --git a/internal/pkg/plugin/githubactions/golang/create.go b/internal/pkg/plugin/githubactions/golang/create.go
@@ -10,11 +10,11 @@ import (
 func Create(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			createDockerHubInfoForPush,
 			github.ProcessAction("create"),
 		},

diff --git a/internal/pkg/plugin/githubactions/golang/delete.go b/internal/pkg/plugin/githubactions/golang/delete.go
@@ -8,11 +8,11 @@ import (
 // Delete remove GitHub Actions workflows.
 func Delete(options map[string]interface{}) (bool, error) {
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			deleteDockerHubInfoForPush,
 			github.ProcessAction("delete"),
 		},

diff --git a/internal/pkg/plugin/githubactions/golang/read.go b/internal/pkg/plugin/githubactions/golang/read.go
@@ -7,7 +7,7 @@ import (
 
 func Read(options map[string]interface{}) (map[string]interface{}, error) {
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},

diff --git a/internal/pkg/plugin/githubactions/golang/update.go b/internal/pkg/plugin/githubactions/golang/update.go
@@ -9,11 +9,11 @@ import (
 // Update remove and set up GitHub Actions workflows.
 func Update(options map[string]interface{}) (map[string]interface{}, error) {
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			deleteDockerHubInfoForPush,
 			createDockerHubInfoForPush,
 			github.ProcessAction("update"),

diff --git a/internal/pkg/plugin/githubactions/nodejs/create.go b/internal/pkg/plugin/githubactions/nodejs/create.go
@@ -10,11 +10,11 @@ import (
 func Create(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			github.Validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			github.ProcessAction("create"),
 		},
 		GetStateOperation: github.GetStaticWorkFlowState,

diff --git a/internal/pkg/plugin/githubactions/nodejs/delete.go b/internal/pkg/plugin/githubactions/nodejs/delete.go
@@ -8,11 +8,11 @@ import (
 // Delete remove GitHub Actions workflows.
 func Delete(options map[string]interface{}) (bool, error) {
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			github.Validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			github.ProcessAction("delete"),
 		},
 	}

diff --git a/internal/pkg/plugin/githubactions/nodejs/read.go b/internal/pkg/plugin/githubactions/nodejs/read.go
@@ -7,7 +7,7 @@ import (
 
 func Read(options map[string]interface{}) (map[string]interface{}, error) {
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			github.Validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},

diff --git a/internal/pkg/plugin/githubactions/nodejs/update.go b/internal/pkg/plugin/githubactions/nodejs/update.go
@@ -9,11 +9,11 @@ import (
 // Update remove and set up GitHub Actions workflows.
 func Update(options map[string]interface{}) (map[string]interface{}, error) {
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			github.Validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			github.ProcessAction("update"),
 		},
 		GetStateOperation: github.GetActionState,

diff --git a/internal/pkg/plugin/githubactions/python/create.go b/internal/pkg/plugin/githubactions/python/create.go
@@ -10,11 +10,11 @@ import (
 func Create(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			github.Validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			createDockerHubInfoForPush,
 			github.ProcessAction("create"),
 		},

diff --git a/internal/pkg/plugin/githubactions/python/delete.go b/internal/pkg/plugin/githubactions/python/delete.go
@@ -8,11 +8,11 @@ import (
 // Delete remove GitHub Actions workflows.
 func Delete(options map[string]interface{}) (bool, error) {
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			github.Validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			deleteDockerHubInfoForPush,
 			github.ProcessAction("delete"),
 		},

diff --git a/internal/pkg/plugin/githubactions/python/read.go b/internal/pkg/plugin/githubactions/python/read.go
@@ -7,7 +7,7 @@ import (
 
 func Read(options map[string]interface{}) (map[string]interface{}, error) {
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			github.Validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},

diff --git a/internal/pkg/plugin/githubactions/python/update.go b/internal/pkg/plugin/githubactions/python/update.go
@@ -9,11 +9,11 @@ import (
 // Update remove and set up GitHub Actions workflows.
 func Update(options map[string]interface{}) (map[string]interface{}, error) {
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			github.Validate,
 			github.BuildWorkFlowsWrapper(workflows),
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			deleteDockerHubInfoForPush,
 			createDockerHubInfoForPush,
 			github.ProcessAction("update"),

diff --git a/internal/pkg/plugin/gitlabcedocker/create.go b/internal/pkg/plugin/gitlabcedocker/create.go
@@ -15,14 +15,14 @@ func Create(options map[string]interface{}) (map[string]interface{}, error) {
 
 	// 2. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			dockerInstaller.Validate,
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			dockerInstaller.Install,
 			showHelpMsg,
 		},
-		TerminateOperations: []plugininstaller.BaseOperation{
+		TerminateOperations: plugininstaller.TerminateOperations{
 			dockerInstaller.ClearWhenInterruption,
 		},
 		GetStateOperation: dockerInstaller.GetStaticStateFromOptions,

diff --git a/internal/pkg/plugin/gitlabcedocker/delete.go b/internal/pkg/plugin/gitlabcedocker/delete.go
@@ -14,10 +14,10 @@ func Delete(options map[string]interface{}) (bool, error) {
 
 	// 2. config delete operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			dockerInstaller.Validate,
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			dockerInstaller.DeleteAll,
 		},
 	}

diff --git a/internal/pkg/plugin/gitlabcedocker/read.go b/internal/pkg/plugin/gitlabcedocker/read.go
@@ -15,7 +15,7 @@ func Read(options map[string]interface{}) (map[string]interface{}, error) {
 
 	// 2. config read operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			dockerInstaller.Validate,
 		},
 		GetStateOperation: dockerInstaller.GetRunningState,

diff --git a/internal/pkg/plugin/gitlabcedocker/update.go b/internal/pkg/plugin/gitlabcedocker/update.go
@@ -19,10 +19,10 @@ func Update(options map[string]interface{}) (map[string]interface{}, error) {
 
 	// 2. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			dockerInstaller.Validate,
 		},
-		ExecuteOperations: []plugininstaller.BaseOperation{
+		ExecuteOperations: plugininstaller.ExecuteOperations{
 			dockerInstaller.DeleteAll,
 			dockerInstaller.Install,
 			showHelpMsg,

diff --git a/internal/pkg/plugin/harbor/create.go b/internal/pkg/plugin/harbor/create.go
@@ -9,7 +9,7 @@ import (
 func Create(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		ExecuteOperations:   helm.DefaultCreateOperations,

diff --git a/internal/pkg/plugin/harbor/delete.go b/internal/pkg/plugin/harbor/delete.go
@@ -8,7 +8,7 @@ import (
 func Delete(options map[string]interface{}) (bool, error) {
 	// 1. config delete operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		ExecuteOperations: helm.DefaultDeleteOperations,

diff --git a/internal/pkg/plugin/harbor/read.go b/internal/pkg/plugin/harbor/read.go
@@ -9,7 +9,7 @@ import (
 func Read(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config read operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		GetStateOperation: helm.GetPluginAllState,

diff --git a/internal/pkg/plugin/harbor/update.go b/internal/pkg/plugin/harbor/update.go
@@ -9,7 +9,7 @@ import (
 func Update(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config update operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		ExecuteOperations: helm.DefaultUpdateOperations,

diff --git a/internal/pkg/plugin/hashicorpvault/create.go b/internal/pkg/plugin/hashicorpvault/create.go
@@ -10,7 +10,7 @@ import (
 func Create(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config install operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		ExecuteOperations:   helm.DefaultCreateOperations,

diff --git a/internal/pkg/plugin/hashicorpvault/delete.go b/internal/pkg/plugin/hashicorpvault/delete.go
@@ -8,7 +8,7 @@ import (
 func Delete(options map[string]interface{}) (bool, error) {
 	// 1. config delete operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		ExecuteOperations: helm.DefaultDeleteOperations,

diff --git a/internal/pkg/plugin/hashicorpvault/read.go b/internal/pkg/plugin/hashicorpvault/read.go
@@ -9,7 +9,7 @@ import (
 func Read(options map[string]interface{}) (map[string]interface{}, error) {
 	// 1. config read operations
 	runner := &plugininstaller.Operator{
-		PreExecuteOperations: []plugininstaller.MutableOperation{
+		PreExecuteOperations: plugininstaller.PreExecuteOperations{
 			helm.Validate,
 		},
 		GetStateOperation: helm.GetPluginAllState,