Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍀 Proposal: upload helm config in cd stage #1296

Closed
steinliber opened this issue Dec 2, 2022 · 0 comments · Fixed by #1315
Closed

🍀 Proposal: upload helm config in cd stage #1296

steinliber opened this issue Dec 2, 2022 · 0 comments · Fixed by #1315
Assignees
@steinliber
Labels
enhancement New feature or request

Comments

@steinliber
Copy link
Contributor

What Would You Like to Add? Why Is This Needed?

Since we now add helm config in repo-scaffolding plugins, we need to render the repo with ImageRepo address, but we can add helm config in CD stage, where this app is deployed, with this we can only use imageRepo in CI/CD only.

Design

  • argocdapp add a step for adding helm config to project
  • ci stage can pass variable to cd

Anything else
@steinliber steinliber self-assigned this Dec 2, 2022
@steinliber steinliber added the enhancement New feature or request label Dec 2, 2022
@steinliber steinliber changed the title 🍀 Proposal: 🍀 Proposal: upload helm config in cd stage Dec 5, 2022
This was referenced Dec 6, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steinliber steinliber

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass variable from ci to cd merico-dev/stream
1 participant
@steinliber