Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass variable from ci to cd #1315

Merged

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Dec 7, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • support share imageRepo config ci stage with cd stage, we only need one imageRepo config for now
  • add more ut for configmanager module and argocdapp module
  • update e2e test
  • use repo-scaffolding without helm configs

Related Issues

close #1296

New Behavior (screenshots if needed)

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@daniel-hutao daniel-hutao merged commit 593ccc2 into devstream-io:main Dec 7, 2022
@daniel-hutao daniel-hutao deleted the feat-apps-cicd-pass-vars branch December 7, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: upload helm config in cd stage
3 participants