Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: dtm list filter flag enhancement #465

Closed
daniel-hutao opened this issue May 11, 2022 · 3 comments
Closed

Proposal: dtm list filter flag enhancement #465

daniel-hutao opened this issue May 11, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@daniel-hutao
Copy link
Member

daniel-hutao commented May 11, 2022

Description

We can now use dtm list plugins --filter {regex} to filter the list of plugins. Thanks for @lyleshaw #462 #463

But dtm list plugins --filter=".repo" -> github-repo-scaffolding-golang is still a bit complicated. If I don't understand regex, then I don't understand what "." means here.

What if dtm be smarter like:

  • input --filter="repo" -> render to --filter=".repo." -> output github-repo-scaffolding-golang
  • input --filter=".repo" -> no render -> output github-repo-scaffolding-golang
  • input --filter="repo." -> no render -> output github-repo-scaffolding-golang

More specifically, when the user input string by --filter contains only alphanumerics and dashes (a,a-b,a1b), we add a "." before and after (.a.,.a-b.,.a1b.).

Note: it's a good-first-issue, can only be assigned by contributors who have not submitted PR.

/cc @lyleshaw @devstream-io/pmc

@daniel-hutao daniel-hutao added the good first issue Good for newcomers label May 11, 2022
@wzymumon
Copy link
Contributor

I wanna try

@daniel-hutao
Copy link
Member Author

I wanna try

Cool, go ahead and happy coding!

/assign @wzymumon

@daniel-hutao
Copy link
Member Author

daniel-hutao commented May 12, 2022

image

feedback from @wzymumon

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants