Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dtm list enhancement #463

Merged
merged 2 commits into from
May 11, 2022
Merged

feat: dtm list enhancement #463

merged 2 commits into from
May 11, 2022

Conversation

lyleshaw
Copy link
Contributor

@lyleshaw lyleshaw commented May 10, 2022 •
edited
Loading

Summary

Key Points

  • This is a breaking change.
  • Documentation (new or existing) is updated.

Description

Use dtm list plugins --filter {regex} command to filter plugins

Related Issues

issue: #462 #384

Screenshots

image

@lyleshaw
Copy link
Contributor Author

BTW, since config-file uses the shorthand f, we should use another shorthand for filter.
In the latest commit, I use r for regex or the latest character of filter. Do you have a better idea?
ping @daniel-hutao

@daniel-hutao
Copy link
Member

BTW, since config-file uses the shorthand f, we should use another shorthand for filter.
In the latest commit, I use r for regex or the latest character of filter. Do you have a better idea?
ping @daniel-hutao

-r / —-filter is ok.
Great Job!

@daniel-hutao daniel-hutao self-requested a review May 11, 2022 00:24
daniel-hutao
daniel-hutao approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@daniel-hutao daniel-hutao merged commit 7e1c9a6 into devstream-io:main May 11, 2022
@daniel-hutao daniel-hutao mentioned this pull request May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-hutao daniel-hutao daniel-hutao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyleshaw @daniel-hutao