Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍀 Proposal: Auto-Release Script Improvement #505

Closed
daniel-hutao opened this issue May 18, 2022 · 2 comments · Fixed by #553
Closed

🍀 Proposal: Auto-Release Script Improvement #505

daniel-hutao opened this issue May 18, 2022 · 2 comments · Fixed by #553
Assignees
Labels
good first issue Good for newcomers

Comments

@daniel-hutao
Copy link
Member

daniel-hutao commented May 18, 2022

What would you like to added? Why is this needed?

We have a release script: build/package/auto-release-darwin-arm64.sh, it starts with:

#! /bin/bash -e
set -o nounset

tag=v0.5.0

So we need to change this tag variable every time when we release a new version, which is obviously inelegant. So, why not set this tag with a parameter? Something like:

sh xxx.sh tag=v0.5.0

By the way, after the script improvement, please move the scripts auto-release-darwin-arm64.sh and upload_assets.sh under the build/package folder to hack/release/.

@daniel-hutao daniel-hutao added the good first issue Good for newcomers label May 18, 2022
@IronCore864 IronCore864 changed the title 🍀 Proposal: auto-release script improvement 🍀 Proposal: auto-release Script Improvement May 18, 2022
@daniel-hutao daniel-hutao changed the title 🍀 Proposal: auto-release Script Improvement 🍀 Proposal: Auto-Release Script Improvement May 18, 2022
@yclchuxue
Copy link
Contributor

I want to do this.

@daniel-hutao
Copy link
Member Author

@yclchuxue Go ahead and happy coding!

/assign @yclchuxue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants