Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Auto-Release Script Improvement #550

Closed
wants to merge 1 commit into from

Conversation

yclchuxue
Copy link
Contributor

@yclchuxue yclchuxue commented May 19, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

When a new version is released, the following methods can be used

sh xxx.sh tag=v0.5.0

Related Issues

There will be a problem if more than one parameter is passed to the auto-release-darwin-arm64.sh file, and the first one is not tag=vx.x.x.

New Behavior (screenshots if needed)

if [ $# -eq 1 ]
then
  info=$1
  tag=${info:4}
fi

@summingyu
Copy link
Contributor

Would it be better to use "getops"?@yclchuxue

@yclchuxue
Copy link
Contributor Author

Doesn't this require the input of parameters like "tag=v0.x.0"? If it is changed to "-t v0.x.0", it may not meet the requirements.Although I also feel it would be better to use getops.

@yclchuxue
Copy link
Contributor Author

@summingyu

@daniel-hutao daniel-hutao changed the title Proposal: Auto-Release Script Improvement Feat: Auto-Release Script Improvement May 19, 2022
@daniel-hutao
Copy link
Member

Related Issues

close #505

@yclchuxue yclchuxue closed this May 19, 2022
@summingyu
Copy link
Contributor

Sorry, I checked the documentation, "getopts" does not support "long options", "getopt" support "long options" @yclchuxue

@yclchuxue
Copy link
Contributor Author

Ok,thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants