Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: complete uts in pkg pkg/utl/template #1007

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

aFlyBird0
Copy link
Member

Signed-off-by: Bird aflybird0@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Related Issues

close #1006

Signed-off-by: Bird <aflybird0@gmail.com>
@aFlyBird0 aFlyBird0 requested a review from a team as a code owner August 18, 2022 05:25
@aFlyBird0 aFlyBird0 requested a review from steinliber August 18, 2022 05:26
@aFlyBird0
Copy link
Member Author

@steinliber PTAL, thank you! ❤️

@steinliber steinliber assigned aFlyBird0 and unassigned steinliber Aug 18, 2022
Signed-off-by: Bird <aflybird0@gmail.com>
@aFlyBird0 aFlyBird0 requested a review from steinliber August 18, 2022 06:49
Copy link
Contributor

@steinliber steinliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-hutao daniel-hutao merged commit 887ae1b into devstream-io:main Aug 18, 2022
@aFlyBird0 aFlyBird0 deleted the test-template branch August 22, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: More unit tests in pkg/util/template
3 participants