-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new backend k8s
and refactor state options validation
#1012
Merged
daniel-hutao
merged 6 commits into
devstream-io:main
from
aFlyBird0:feat-backend-configmap
Aug 19, 2022
Merged
feat: new backend k8s
and refactor state options validation
#1012
daniel-hutao
merged 6 commits into
devstream-io:main
from
aFlyBird0:feat-backend-configmap
Aug 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aFlyBird0
force-pushed
the
feat-backend-configmap
branch
2 times, most recently
from
August 19, 2022 05:55
86eb626
to
ce4ce17
Compare
aFlyBird0
force-pushed
the
feat-backend-configmap
branch
from
August 19, 2022 06:03
ce4ce17
to
63b0674
Compare
aFlyBird0
changed the title
feat: new backend
feat: new backend Aug 19, 2022
k8s
k8s
and refactor state options validation
aFlyBird0
commented
Aug 19, 2022
IronCore864
approved these changes
Aug 19, 2022
steinliber
reviewed
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
daniel-hutao
requested changes
Aug 19, 2022
iyear
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aFlyBird0
force-pushed
the
feat-backend-configmap
branch
from
August 19, 2022 08:31
1902241
to
92974ee
Compare
Wait for #1005 to be merged. |
Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
…rding to review comments Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
aFlyBird0
force-pushed
the
feat-backend-configmap
branch
from
August 19, 2022 12:52
160ae52
to
326126d
Compare
daniel-hutao
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bird aflybird0@gmail.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
backend
during callingGetBackend
to unify and remove duplicate validations.Related Issues
close #995
New Behavior (screenshots if needed)