Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new backend k8s and refactor state options validation #1012

Merged
merged 6 commits into from
Aug 19, 2022

Conversation

aFlyBird0
Copy link
Member

@aFlyBird0 aFlyBird0 commented Aug 18, 2022

Signed-off-by: Bird aflybird0@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • Use K8s ConfigMap as a backend.
  • Validate backend options in pkg backend during calling GetBackend to unify and remove duplicate validations.

Related Issues

close #995

New Behavior (screenshots if needed)

image

image

image

@aFlyBird0 aFlyBird0 changed the title feat: new backend ConfigMap feat: new backend k8s Aug 19, 2022
@aFlyBird0 aFlyBird0 force-pushed the feat-backend-configmap branch 2 times, most recently from 86eb626 to ce4ce17 Compare August 19, 2022 05:55
@aFlyBird0 aFlyBird0 marked this pull request as ready for review August 19, 2022 06:00
@aFlyBird0 aFlyBird0 requested review from IronCore864 and a team as code owners August 19, 2022 06:00
@aFlyBird0 aFlyBird0 force-pushed the feat-backend-configmap branch from ce4ce17 to 63b0674 Compare August 19, 2022 06:03
@aFlyBird0 aFlyBird0 changed the title feat: new backend k8s feat: new backend k8s and refactor state options validation Aug 19, 2022
Copy link
Contributor

@steinliber steinliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/pkg/backend/backend.go Show resolved Hide resolved
internal/pkg/backend/backend.go Outdated Show resolved Hide resolved
internal/pkg/backend/backend.go Outdated Show resolved Hide resolved
docs/core-concepts/stateconfig.md Outdated Show resolved Hide resolved
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aFlyBird0 aFlyBird0 force-pushed the feat-backend-configmap branch from 1902241 to 92974ee Compare August 19, 2022 08:31
@aFlyBird0
Copy link
Member Author

aFlyBird0 commented Aug 19, 2022

Wait for #1005 to be merged.

Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
…rding to review comments

Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
@aFlyBird0 aFlyBird0 force-pushed the feat-backend-configmap branch from 160ae52 to 326126d Compare August 19, 2022 12:52
@aFlyBird0 aFlyBird0 requested a review from daniel-hutao August 19, 2022 12:53
@daniel-hutao daniel-hutao merged commit e2cb800 into devstream-io:main Aug 19, 2022
@aFlyBird0 aFlyBird0 deleted the feat-backend-configmap branch August 22, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: Add k8s as a Backend of the State
5 participants