Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: SCM git client #1048

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Sep 2, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • Github reposcaffloding will delete placeholder file
  • put scm logic in pkg/util

Related Issues

close #1047

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber requested a review from a team as a code owner September 2, 2022 03:26
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Is there some misuse here?

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@IronCore864 IronCore864 merged commit eeede2e into devstream-io:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: put scm logic in pkg/util
4 participants