feat: Optimize helm pkg #1076
Merged
feat: Optimize helm pkg #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxxhero
force-pushed
the
optimize_helm_pkg
branch
from
1339cf8 to
63490c7
Compare
Signed-off-by: yxxhero <aiopsclub@163.com>
yxxhero
force-pushed
the
optimize_helm_pkg
branch
from
63490c7 to
f944546
Compare
steinliber
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Hi @yxxhero, thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!
Here are a few useful things for you to continue your open-source journey:
- If you are searching for something else to work on, please see "find an issue".
- Check out our new contributor guide and the "Developer Guide".
- Read our blog; they are on Medium, too.
|
LGTM, Great code! |
IronCore864
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
Related Issues
Fixed: #1075
New Behavior (screenshots if needed)