Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add plugin sonar #1089

Merged
merged 1 commit into from
Sep 20, 2022
Merged

feat: add plugin sonar #1089

merged 1 commit into from
Sep 20, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Sep 14, 2022 •
edited
Loading

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • Add plugin Sonarqube.
  • Add plugin Sonarqube chinese docs.

Related Issues

#993
#639

@steinliber steinliber requested review from IronCore864 and a team as code owners September 14, 2022 14:04
aFlyBird0
aFlyBird0 requested changes Sep 16, 2022
View reviewed changes
docs/plugins/sonarqube.zh.md Outdated Show resolved Hide resolved
docs/plugins/sonarqube.zh.md Outdated Show resolved Hide resolved
docs/plugins/sonarqube.zh.md Outdated Show resolved Hide resolved
docs/plugins/sonarqube.zh.md Outdated Show resolved Hide resolved
docs/plugins/sonarqube.zh.md Outdated Show resolved Hide resolved
internal/pkg/plugin/sonarqube/create.go Show resolved Hide resolved
iyear
iyear reviewed Sep 16, 2022
View reviewed changes
docs/plugins/sonarqube.zh.md Outdated Show resolved Hide resolved
iyear
iyear reviewed Sep 16, 2022
View reviewed changes
docs/plugins/sonarqube.zh.md Outdated Show resolved Hide resolved
@steinliber
feat: add plugin sonar
4dd2a18 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber assigned aFlyBird0 and unassigned steinliber Sep 16, 2022
@daniel-hutao daniel-hutao assigned iyear and unassigned IronCore864 Sep 19, 2022
iyear
iyear approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@daniel-hutao daniel-hutao merged commit 828e79e into devstream-io:main Sep 20, 2022
@daniel-hutao daniel-hutao deleted the feat-plugin-sonar branch September 20, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyear iyear iyear approved these changes

@aFlyBird0 aFlyBird0 aFlyBird0 approved these changes

@daniel-hutao daniel-hutao daniel-hutao approved these changes

@IronCore864 IronCore864 Awaiting requested review from IronCore864

Assignees

@iyear iyear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@steinliber @daniel-hutao @aFlyBird0 @iyear @IronCore864