Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Jenkins repo support private repo #1105

Merged
merged 4 commits into from
Sep 21, 2022
Merged

feat: Jenkins repo support private repo #1105

merged 4 commits into from
Sep 21, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Sep 19, 2022 •
edited
Loading

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • Jenkins support clone private repo
  • delete scm.projectRepo and scm.projectBranch field
  • add scm.cloneURL for clone config, scm.apiURL for api request, scm.branch for repo branch config
  • add GITLAB_SSHKEY environment variable for private repo

Related Issues

#993

New Behavior (screenshots if needed)

  • create Jenkins credential for private key
    image
  • create job with this credential
    image

@steinliber
feat: jenkins repo support private repo
e272e45 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber requested review from IronCore864 and a team as code owners September 19, 2022 09:40
@steinliber
fix: code conflict
74a7024 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber
fix: doc error
50af4c6 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber
fix: log message error
358c15d 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@daniel-hutao
Copy link
Member

Remember close #1102 after this pr merged.

@steinliber steinliber assigned aFlyBird0 and unassigned steinliber Sep 20, 2022
@steinliber steinliber assigned IronCore864 and unassigned aFlyBird0 Sep 21, 2022
@daniel-hutao daniel-hutao merged commit 9779212 into devstream-io:main Sep 21, 2022
@daniel-hutao daniel-hutao deleted the feat-jenkins-support-private-repo branch September 21, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aFlyBird0 aFlyBird0 aFlyBird0 approved these changes

@daniel-hutao daniel-hutao daniel-hutao approved these changes

@IronCore864 IronCore864 Awaiting requested review from IronCore864

Assignees

@IronCore864 IronCore864

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steinliber @daniel-hutao @aFlyBird0 @IronCore864