Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jenkins-pipeline support dingtalk and sonar #1148

Merged

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Oct 6, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • jenkins-pipeline support dingtalk config
  • jenkins-pipeline support sonarqube config
  • jenkins-pipeline struct support more plugins

Related Issues

#993 #1086 #639

New Behavior (screenshots if needed)

dingtalk
image
image
sonarqube
image
image

@steinliber steinliber marked this pull request as ready for review October 6, 2022 11:48
@steinliber steinliber requested a review from a team as a code owner October 6, 2022 11:48
@steinliber steinliber force-pushed the feat-jenkins-support-dingtalk branch 3 times, most recently from 3f0ee52 to 64130a3 Compare October 7, 2022 13:45
@aFlyBird0 aFlyBird0 self-assigned this Oct 8, 2022
@aFlyBird0 aFlyBird0 self-requested a review October 8, 2022 01:39
Copy link
Member

@aFlyBird0 aFlyBird0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your hard work!

internal/pkg/plugininstaller/jenkins/pipeline.go Outdated Show resolved Hide resolved
internal/pkg/plugininstaller/jenkins/pipeline.go Outdated Show resolved Hide resolved
internal/pkg/plugininstaller/jenkins/pipeline.go Outdated Show resolved Hide resolved
internal/pkg/plugininstaller/jenkins/plugins/dingtalk.go Outdated Show resolved Hide resolved
internal/pkg/plugininstaller/jenkins/plugins/dingtalk.go Outdated Show resolved Hide resolved
internal/pkg/plugininstaller/jenkins/plugins/imagerepo.go Outdated Show resolved Hide resolved
@aFlyBird0 aFlyBird0 assigned steinliber and unassigned aFlyBird0 Oct 8, 2022
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber force-pushed the feat-jenkins-support-dingtalk branch from 9174bbd to 8a4d2ee Compare October 8, 2022 05:58
@steinliber steinliber assigned aFlyBird0 and unassigned steinliber Oct 8, 2022
@aFlyBird0 aFlyBird0 assigned daniel-hutao and unassigned aFlyBird0 Oct 8, 2022
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steinliber Please remember to add some documents with sonarqube and dingtalk.

@daniel-hutao daniel-hutao merged commit f56c8b7 into devstream-io:main Oct 9, 2022
@daniel-hutao daniel-hutao deleted the feat-jenkins-support-dingtalk branch October 9, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants