Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add New Plugin devlake-config #1167

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

daniel-hutao
Copy link
Member

@daniel-hutao daniel-hutao commented Oct 11, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Add new plugin devlake-config to config DevLake.

@warren830 has tested this pr and everything works fine.

Related Issues

N/A

New Behavior (screenshots if needed)

DevLake connection configuration support.

TODO

Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@daniel-hutao daniel-hutao force-pushed the feat-devlake branch 2 times, most recently from 74b3113 to 0b3bec7 Compare October 11, 2022 14:15
@daniel-hutao daniel-hutao marked this pull request as ready for review October 11, 2022 14:20
@daniel-hutao daniel-hutao requested review from IronCore864 and a team as code owners October 11, 2022 14:20
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@daniel-hutao daniel-hutao requested review from iyear and removed request for steinliber October 11, 2022 15:01
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@warren830 warren830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@daniel-hutao daniel-hutao merged commit f4231d6 into devstream-io:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants