Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ci generic use go getter to get resource #1170

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Oct 13, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • use go-getter to get ci files and download repo.
  • add more ut in ci-generic.
  • delte unzip code.
  • change ci config fields.

Related Issues

#521 #522

New Behavior (screenshots if needed)

  • support download ci files from scm repo

@steinliber steinliber requested review from IronCore864 and a team as code owners October 13, 2022 06:44
@aFlyBird0 aFlyBird0 self-requested a review October 13, 2022 08:09
@aFlyBird0 aFlyBird0 self-assigned this Oct 13, 2022
pkg/util/downloader/resource.go Outdated Show resolved Hide resolved
pkg/util/downloader/resource.go Show resolved Hide resolved
pkg/util/downloader/resource.go Outdated Show resolved Hide resolved
pkg/util/downloader/resource.go Outdated Show resolved Hide resolved
@aFlyBird0 aFlyBird0 removed their assignment Oct 13, 2022
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@IronCore864 IronCore864 merged commit 845e66d into devstream-io:main Oct 14, 2022
@IronCore864 IronCore864 deleted the refactor-ci-generic branch October 14, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants