Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app support ci/cd default config for app.spec #1259

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Nov 25, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • repair configField: [[ var1 ]]/[[ var2 ]] error

  • support default option for app.spec

  • to change image Repo Key

Related Issues

#1239

New Behavior (screenshots if needed)

use config below

config:
  state:
    backend: local
    options:
      stateFile: devstream.state

vars:
  repoOwner: steinliber
  repoTemplateBaseURL: github.com/devstream-io
  imageRepoOwner: steinsliber

tools:
- name: helm-installer
  instanceID: argocd-001

apps:
- name: myapp1
  spec:
    language: python
    framework: django
  repo:
    url: github.com/[[ repoOwner ]]/myapp1
  repoTemplate:
    url: [[ repoTemplateBaseURL ]]/dtm-scaffolding-python
    vars:
      ImageRepo: [[ imageRepoOwner ]]/myapp1
  ci:
  - type: github-actions
    options:
      imageRepo:
        user: [[ imageRepoOwner ]]
  - type: argocdapp
- name: myapp2
  spec:
    framework: gin
    language: golang
  repo:
    owner: [[ repoOwner ]]
    scmType: github
  repoTemplate:
    url: [[ repoTemplateBaseURL ]]/dtm-scaffolding-golang
    vars:
      ImageRepo: [[ imageRepoOwner ]]/myapp2
  ci:
  - type: github-actions
    options:
      imageRepo:
        user: [[ imageRepoOwner ]]
  cd:
  - type: argocdapp

repo and action is created

image
image

app is created

image

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@daniel-hutao daniel-hutao merged commit 350f65e into devstream-io:main Nov 26, 2022
@daniel-hutao daniel-hutao deleted the feat-app-spec-option branch November 26, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants