-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for rollback in case of error in intermediate steps #1379
Conversation
Signed-off-by: 0zyt <zyt0@duck.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you use number to represent different stages, I think you can use golang's iota
to do this kind of job, which will make the code become more clear
@KeHaohaoke Please help to fix the ci error here. It seems like a configuration issue with build machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the steps to roll back
Signed-off-by: 0zyt <zyt0@duck.com>
modified |
Signed-off-by: 0zyt <zyt0@duck.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like your code has been off the main branch for two months.
Please run git fetch upstream && git rebase upstream/main
on the current branch first to update the code.
(If you are not particularly proficient with git, it is recommended that you back up your current code changes first)
I have merged the main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Signed-off-by: 0zyt zyt0@duck.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
When an error occurs while updating, roll back
Related Issues
#1173
New Behavior (screenshots if needed)