Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use config field instead of env #1389

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

steinliber
Copy link
Contributor

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • BREAK CHANGE: now you should set scm.token instead of use env

  • update docs for this config

Related Issues

#1211

New Behavior (screenshots if needed)

image

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-hutao
Copy link
Member

Good job!

So, we need to update some documents accordingly.

e.g. https://docs.devstream.io/en/latest/use-cases/gitlab-jenkins-harbor/5-java-springboot-pipeline-with-gitlab-jenkins-harbor.zh/

Maybe in the next pr. @steinliber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants