Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new plugin - gitlabci-generic #396

Merged
merged 6 commits into from
Apr 8, 2022
Merged

feat: new plugin - gitlabci-generic #396

merged 6 commits into from
Apr 8, 2022

Conversation

IronCore864
Copy link
Member

Summary

Key Points

  • Documentation (new or existing) is updated.

Description

  • new plugin: gitlabci-generic
  • it takes two extra inputs: template URL and template variables
  • it downloads the template, then renders it using the given variables
  • docs are also updated
  • dtm develop document related refactor according to recent doc refactor
  • added to dtm show as well

@IronCore864 IronCore864 requested a review from daniel-hutao April 7, 2022 12:38
@daniel-hutao daniel-hutao requested a review from imxw April 7, 2022 12:40
@daniel-hutao
Copy link
Member

/approve

@daniel-hutao daniel-hutao requested review from imxw and daniel-hutao and removed request for imxw and daniel-hutao April 7, 2022 13:17
@daniel-hutao daniel-hutao requested a review from imxw April 7, 2022 13:18
@IronCore864 IronCore864 merged commit da8b1c3 into devstream-io:main Apr 8, 2022
@IronCore864 IronCore864 deleted the feat-new-plugin-gitlabci-generic branch April 8, 2022 00:59
@IronCore864 IronCore864 added the enhancement New feature or request label May 18, 2022
@IronCore864 IronCore864 self-assigned this May 18, 2022
@IronCore864
Copy link
Member Author

Closes #377

@IronCore864 IronCore864 mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imxw imxw imxw left review comments

@daniel-hutao daniel-hutao daniel-hutao approved these changes

Assignees

@IronCore864 IronCore864

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IronCore864 @daniel-hutao @imxw