Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding the missing config field for most plugins. #416

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

daniel-hutao
Copy link
Member

Signed-off-by: Daniel Hu tao.hu@merico.dev

Summary

Adding the missing config field for most plugins.

@daniel-hutao daniel-hutao self-assigned this Apr 15, 2022
options:
owner: YOUR_GITHUB_USERNAME
repo: YOUR_REPO_NAME
kanbanBoardName: KANBAN_BOARD_NAME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think it's better to keep trello plugin config, since trello-github-integ depends on its outputs.

Copy link
Member

@IronCore864 IronCore864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment, only one small question.

Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@daniel-hutao daniel-hutao merged commit 815ebe0 into devstream-io:main Apr 15, 2022
@daniel-hutao daniel-hutao deleted the fix-config branch April 15, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants