Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: some small changes with validate-plugin command #453

Merged
merged 2 commits into from
May 9, 2022

Conversation

daniel-hutao
Copy link
Member

Signed-off-by: Daniel Hu tao.hu@merico.dev

Summary

Some small changes with validate-plugin command

Related Issues

#443

#436

TODO

@summingyu I slightly optimized the log printing and added lost files to some plugins. Now many of the remaining plugins fail to pass the verification is not a problem of plugins, but a problem of verification rules. For example, the package name of plugin kube-prometheus is kubeprometheus, which is actually reasonable. So our validation rules need to be more precise.

Screenshots

./dtm develop  validate-plugin --all                                                                                            
2022-05-08 22:42:53 ℹ [INFO]  Start validating all plugins.

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <argocd> =====
2022-05-08 22:42:53 ✔ [SUCCESS]  Plugin <argocd> passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <argocd> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <argocdapp> =====
2022-05-08 22:42:53 ✔ [SUCCESS]  Plugin <argocdapp> passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <argocdapp> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <devlake> =====
2022-05-08 22:42:53 ✔ [SUCCESS]  Plugin <devlake> passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <devlake> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <github-repo-scaffolding-golang> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/github-repo-scaffolding-golang/github-repo-scaffolding-golang.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/github-repo-scaffolding-golang/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/github-repo-scaffolding-golang/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/github-repo-scaffolding-golang/: no such file or directory
stat internal/pkg/plugin/github-repo-scaffolding-golang/: no such file or directory
stat internal/pkg/plugin/github-repo-scaffolding-golang/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <github-repo-scaffolding-golang> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <github-repo-scaffolding-golang> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <githubactions-golang> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/githubactions-golang/githubactions-golang.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/githubactions-golang/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/githubactions-golang/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/githubactions-golang/: no such file or directory
stat internal/pkg/plugin/githubactions-golang/: no such file or directory
stat internal/pkg/plugin/githubactions-golang/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <githubactions-golang> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <githubactions-golang> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <githubactions-nodejs> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/githubactions-nodejs/githubactions-nodejs.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/githubactions-nodejs/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/githubactions-nodejs/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/githubactions-nodejs/: no such file or directory
stat internal/pkg/plugin/githubactions-nodejs/: no such file or directory
stat internal/pkg/plugin/githubactions-nodejs/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <githubactions-nodejs> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <githubactions-nodejs> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <githubactions-python> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/githubactions-python/githubactions-python.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/githubactions-python/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/githubactions-python/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/githubactions-python/: no such file or directory
stat internal/pkg/plugin/githubactions-python/: no such file or directory
stat internal/pkg/plugin/githubactions-python/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <githubactions-python> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <githubactions-python> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <gitlab-repo-scaffolding-golang> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/gitlab-repo-scaffolding-golang/gitlab-repo-scaffolding-golang.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/gitlab-repo-scaffolding-golang/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/gitlab-repo-scaffolding-golang/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/gitlab-repo-scaffolding-golang/: no such file or directory
stat internal/pkg/plugin/gitlab-repo-scaffolding-golang/: no such file or directory
stat internal/pkg/plugin/gitlab-repo-scaffolding-golang/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <gitlab-repo-scaffolding-golang> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <gitlab-repo-scaffolding-golang> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <gitlabci-generic> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/gitlabci-generic/gitlabci-generic.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/gitlabci-generic/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/gitlabci-generic/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/gitlabci-generic/: no such file or directory
stat internal/pkg/plugin/gitlabci-generic/: no such file or directory
stat internal/pkg/plugin/gitlabci-generic/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <gitlabci-generic> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <gitlabci-generic> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <gitlabci-golang> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/gitlabci-golang/gitlabci-golang.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/gitlabci-golang/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/gitlabci-golang/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/gitlabci-golang/: no such file or directory
stat internal/pkg/plugin/gitlabci-golang/: no such file or directory
stat internal/pkg/plugin/gitlabci-golang/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <gitlabci-golang> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <gitlabci-golang> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <hashicorp-vault> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/hashicorp-vault/hashicorp-vault.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/hashicorp-vault/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/hashicorp-vault/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/hashicorp-vault/: no such file or directory
stat internal/pkg/plugin/hashicorp-vault/: no such file or directory
stat internal/pkg/plugin/hashicorp-vault/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <hashicorp-vault> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <hashicorp-vault> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <helm-generic> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/helm-generic/helm-generic.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/helm-generic/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/helm-generic/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/helm-generic/: no such file or directory
stat internal/pkg/plugin/helm-generic/: no such file or directory
stat internal/pkg/plugin/helm-generic/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <helm-generic> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <helm-generic> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <jenkins> =====
2022-05-08 22:42:53 ✔ [SUCCESS]  Plugin <jenkins> passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <jenkins> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <jira-github-integ> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/jira-github-integ/jira-github-integ.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/jira-github-integ/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/jira-github-integ/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/jira-github-integ/: no such file or directory
stat internal/pkg/plugin/jira-github-integ/: no such file or directory
stat internal/pkg/plugin/jira-github-integ/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <jira-github-integ> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <jira-github-integ> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <kube-prometheus> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/kube-prometheus/kube-prometheus.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/kube-prometheus/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/kube-prometheus/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/kube-prometheus/: no such file or directory
stat internal/pkg/plugin/kube-prometheus/: no such file or directory
stat internal/pkg/plugin/kube-prometheus/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <kube-prometheus> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <kube-prometheus> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <openldap> =====
2022-05-08 22:42:53 ✔ [SUCCESS]  Plugin <openldap> passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <openldap> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <trello> =====
2022-05-08 22:42:53 ✔ [SUCCESS]  Plugin <trello> passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <trello> =====

2022-05-08 22:42:53 ℹ [INFO]  ===== start validating <trello-github-integ> =====
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/trello-github-integ/trello-github-integ.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/trello-github-integ/create.go.
2022-05-08 22:42:53 ✖ [ERROR]  Failed to validate: internal/pkg/plugin/trello-github-integ/delete.go.
2022-05-08 22:42:53 ✖ [ERROR]  stat internal/pkg/plugin/trello-github-integ/: no such file or directory
stat internal/pkg/plugin/trello-github-integ/: no such file or directory
stat internal/pkg/plugin/trello-github-integ/: no such file or directory
2022-05-08 22:42:53 ✖ [ERROR]  Plugin <trello-github-integ> does NOT passed validation.
2022-05-08 22:42:53 ℹ [INFO]  ===== Finished validate <trello-github-integ> =====

Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@IronCore864 IronCore864 merged commit 5ea588c into devstream-io:main May 9, 2022
@IronCore864 IronCore864 deleted the fix-2 branch May 9, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants