Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dtm develop create-plugin enhancement #456

Merged
merged 2 commits into from
May 9, 2022

Conversation

aeinrw
Copy link
Contributor

@aeinrw aeinrw commented May 9, 2022

Summary

Key Points

  • This is a breaking change.
  • Documentation (new or existing) is updated.

Description

  1. fix issues Proposal: dtm develop create-plugin enhancement #454
  2. add a new file funcmaps.go

Related Issues

#454

Screenshots

image

image

@daniel-hutao
Copy link
Member

@aeinrw Hi aeinrw, thanks for your great pr! Please contact me on WeChat(If you don't know how-to, you can send me an email, the email address can be found on my GitHub homepage).

I'd like to invite you be a "DevStream Community Contributor" and to give you some gift about Contributor.

@daniel-hutao
Copy link
Member

daniel-hutao commented May 9, 2022

Your code is great. There is one detail that needs to be adjusted, that is, in addition to the package name, the directory name needs to be the same as the package name.

internal/pkg/test-plugin -> internal/pkg/testplugin

But don't change the cmd/plugin/test-pugin, it's right.

@daniel-hutao daniel-hutao self-requested a review May 9, 2022 13:38
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment above.

Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

GOOD JOB!

@daniel-hutao daniel-hutao merged commit 74e3ead into devstream-io:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants