Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add s3 backend #486

Merged
merged 2 commits into from
May 19, 2022
Merged

Conversation

algobot76
Copy link
Contributor

@algobot76 algobot76 commented May 15, 2022

Summary

This PR implements the S3 backend.

Key Points

  • This is a breaking change.
  • Documentation (new or existing) is updated.

Description

Although the S3 backend has been made possible, the current codebase is hardcoded to use the local backend. It needs to be refactored such that dtm uses the S3 backend according to the state type in config.yaml. See

b, err := backend.GetBackend(backend.Local)

Related Issues

#485

Screenshots

image

@algobot76 algobot76 force-pushed the add-s3-backend branch 5 times, most recently from 5ef648e to 7cd504d Compare May 16, 2022 15:50
@algobot76 algobot76 changed the title [WIP] feat: add s3 backend feat: add s3 backend May 16, 2022
@algobot76 algobot76 marked this pull request as ready for review May 16, 2022 16:01
@daniel-hutao daniel-hutao requested a review from IronCore864 May 17, 2022 09:53
@IronCore864 IronCore864 merged commit 01c7b7b into devstream-io:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants