Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modify args to subcommand in dtm develop #512

Merged
merged 1 commit into from
May 18, 2022
Merged

refactor: modify args to subcommand in dtm develop #512

merged 1 commit into from
May 18, 2022

Conversation

xavier-hou
Copy link
Member

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Modify create-plugin and validate-plugin from developAction(arguments) to subcommand.

Related Issues

#493

New Behavior (screenshots if needed)

  • dtm develop
    image

  • dtm develop create-plugin
    image

  • dtm develop validate-plugin
    image

@xavier-hou
Copy link
Member Author

Further consideration is needed.

Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments above.

@daniel-hutao daniel-hutao self-requested a review May 18, 2022 13:32
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daniel-hutao daniel-hutao merged commit 3830789 into devstream-io:main May 18, 2022
@daniel-hutao daniel-hutao added the enhancement New feature or request label May 18, 2022
@daniel-hutao daniel-hutao added this to the dtm-v0.6.0 milestone May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants