refactor: use validator to validate fields #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review carefully, there are too many changes😥 |
fix: docker nil
daniel-hutao
requested changes
May 19, 2022
|
I've tested a normal use case for the following plugins:
And it worked. Didn't regression-test all plugins or abnormal cases. |
|
@iyear thanks for this great improvement. |
IronCore864
requested changes
May 19, 2022
|
A very good proposal and an elegant solution. Keep up the good work! It's not easy to test all plugins in this PR. I'll create an issue for each plugin to improve. |
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#511
I didn't test every plugin, but I checked them all as much as I could.
Some of the validation rules are too complicated. For example:
githubactions/golang/validate.go, I kept some of the original validation rules.