Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add s3 support, and create key if not exist #546

Merged
merged 8 commits into from
May 19, 2022
Merged

Conversation

IronCore864
Copy link
Member

@IronCore864 IronCore864 commented May 19, 2022

Description

Building on top of @algobot76's work:

  • refactor to enable s3 backend;
  • add a feature that when first using the s3 backend and the key doesn't exist, create the key automatically.

Docs update is in another PR: #548.

Related Issues

Closes #485, #378.

New Behavior (screenshots if needed)

config:

state:
  backend: s3
  options:
    bucket: devstream-test-remote-state
    region: ap-southeast-1
    key: devstream.state

Test

Screen Shot 2022-05-19 at 16 42 30

@IronCore864 IronCore864 self-assigned this May 19, 2022
@IronCore864 IronCore864 added the enhancement New feature or request label May 19, 2022
@IronCore864 IronCore864 added this to the dtm-v0.6.0 milestone May 19, 2022
@IronCore864 IronCore864 linked an issue May 19, 2022 that may be closed by this pull request
@daniel-hutao daniel-hutao merged commit aec6c80 into main May 19, 2022
@daniel-hutao daniel-hutao deleted the add-s3-backend branch May 19, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: S3 Backend 🍀 Proposal: Add Remote State Support
4 participants