Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .gitattributes to unify different platforms eol #554

Merged
merged 2 commits into from
May 20, 2022

Conversation

iyear
Copy link
Member

@iyear iyear commented May 19, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Maybe it's a breaking change.
Windows users may have all files changed after pulling the latest code, so just delete all files except .gitattributes .git and roll them back to reset the eol.Or nothing may happen, just make sure to show the eol of all text files as LF in the IDE

Add .gitattributes to unify different platforms eol

Related Issues

#541

New Behavior (screenshots if needed)

After I run make fmt in WSL, no file changed.
image

@iyear
Copy link
Member Author

iyear commented May 19, 2022

And now it's LF in Goland.

image

.gitattributes Outdated Show resolved Hide resolved
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@daniel-hutao
Copy link
Member

close #541

/cc @iyear Please see the document here about how to close a issue with comment. And remember close the issue with pr comment next time.

@daniel-hutao daniel-hutao merged commit 219030e into devstream-io:main May 20, 2022
@iyear
Copy link
Member Author

iyear commented May 20, 2022

@daniel-hutao @IronCore864 Thanks for the review and help! My mistake:(, I will pay attention next time.

Related Links: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants