Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused files #555

Merged
merged 1 commit into from
May 20, 2022
Merged

chore: remove unused files #555

merged 1 commit into from
May 20, 2022

Conversation

xavier-hou
Copy link
Member

Description

  1. Remove cmd/devstream/options/validator.go
  2. Remove internal/pkg/show/show.go

Maybe these two files are not needed any more.

Related Issues

#549

@IronCore864
Copy link
Member

Git commit message lint failed. We use the conventional commits: https://github.com/devstream-io/devstream/blob/main/CONTRIBUTING.md#git-commit-message. Please stick to the standard. Thanks for the contribution!

@xavier-hou
Copy link
Member Author

My bad. I forgot to add the space after the colon. Thanks for your reply.

@daniel-hutao daniel-hutao self-requested a review May 20, 2022 02:41
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daniel-hutao daniel-hutao merged commit 91e46e0 into devstream-io:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants