Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add editorconfig #626

Merged
merged 2 commits into from
May 30, 2022
Merged

feat: add editorconfig #626

merged 2 commits into from
May 30, 2022

Conversation

iyear
Copy link
Member

@iyear iyear commented May 28, 2022 •
edited by IronCore864
Loading

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

add .editorconfig to add new line at eof automatically.

https://stackoverflow.com/a/41127396

Closes #629

daniel-hutao
daniel-hutao approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Please take a review at this pr @IronCore864

@daniel-hutao daniel-hutao added the enhancement New feature or request label May 28, 2022
@iyear
Copy link
Member Author

iyear commented May 28, 2022 •
edited
Loading

Goland supports the editorconfig feature. vsc requires a plugin to be installed to support it. But it's better than nothing.

https://www.jetbrains.com/help/go/configuring-code-style.html#editorconfig

@algobot76
Copy link
Contributor

We could set more options to the .editorconfig file, see: https://github.com/kubernetes/dashboard/blob/master/.editorconfig

@IronCore864
Copy link
Member

We could set more options to the .editorconfig file, see: https://github.com/kubernetes/dashboard/blob/master/.editorconfig

Great suggestion. Let me copy-paste that XD

@IronCore864
Copy link
Member

Thanks @iyear for the quality-of-life improvement idea and thanks @algobot76 for contributing more to it.

@IronCore864
Copy link
Member

Closes #629.

@IronCore864 IronCore864 merged commit 65351ac into devstream-io:main May 30, 2022
@iyear iyear deleted the add-editorconfig branch May 31, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronCore864 IronCore864 IronCore864 approved these changes

@daniel-hutao daniel-hutao daniel-hutao approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: editorconfig
4 participants
@iyear @algobot76 @IronCore864 @daniel-hutao